Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Avatar by upload .glb file on admin system #5312

Merged
merged 18 commits into from
Mar 8, 2022
Merged

Create Avatar by upload .glb file on admin system #5312

merged 18 commits into from
Mar 8, 2022

Conversation

kimenyikevin
Copy link

@kimenyikevin kimenyikevin commented Feb 23, 2022 •
edited
Loading

Summary

A summary of changes being made in this PR

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@kimenyikevin kimenyikevin linked an issue Feb 23, 2022 that may be closed by this pull request
Create Avatar by upload .glb file on admin system #5189
Closed
@kimenyikevin kimenyikevin marked this pull request as ready for review February 28, 2022 11:18
@zulqarnainhanif
Copy link
Contributor

@kimenyikevin npm run format in the your repo to fix the linting warnings

zulqarnainhanif
zulqarnainhanif reviewed Feb 28, 2022
View reviewed changes
packages/client-core/src/admin/services/AvatarService.ts Outdated
files: [blob, thumbnail],
args: [
{
key: 'avatars/public/CyberbotGold.glb',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to this fixed argument any avatar i upload update the CyberGold.glb entry

zulqarnainhanif
zulqarnainhanif reviewed Feb 28, 2022
View reviewed changes
packages/client-core/src/admin/services/AvatarService.ts Outdated
files: [blob, thumbnail],
args: [
{
key: 'avatars/public/CyberbotGold.glb',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to this fixed argument any avatar i upload update the CyberGold.glb entry

zulqarnainhanif
zulqarnainhanif reviewed Mar 1, 2022
View reviewed changes
packages/client-core/src/admin/services/AvatarService.ts Outdated
files: [blob, thumbnail],
args: [
{
key: `avatars/public/${thumbnail['name']}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make it more uniwue you can append unicode timestamp with file name as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason for this is because if a person accidentally uploads the same name for a new avatar file, it updates the previous avatar rather than adding a new one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made changes from backend, That is where i modify key property

@zulqarnainhanif
Copy link
Contributor

@kimenyikevin

  • need to show a centralized face view of the avatar in image

Screenshot 2022-03-01 at 9 09 59 AM

  • there should be option to upload file in edit menu as well

Screenshot 2022-03-01 at 9 10 28 AM

  • You can centralised or make a full width view of upload button and avatar uploaded preview.

Screenshot 2022-03-01 at 9 13 18 AM

@zulqarnainhanif
Copy link
Contributor

@kimenyikevin the following things needs to be fixed:

  • The view model of avatar is neither showing avatar nor its thumbnail correctly

Screenshot 2022-03-04 at 12 20 04 AM

  • After updating an avatar if you click view again it shows the old avatar until a manual refresh is done.

  • Avatar edit model isn't showing full width view of avatar like create model

Screenshot 2022-03-04 at 12 17 28 AM

@zulqarnainhanif zulqarnainhanif merged commit f7d6553 into dev Mar 8, 2022
@zulqarnainhanif zulqarnainhanif deleted the bg-fix-style branch March 8, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zulqarnainhanif zulqarnainhanif zulqarnainhanif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Avatar by upload .glb file on admin system
2 participants
@kimenyikevin @zulqarnainhanif