Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added podName column to instance model. #5369

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Added podName column to instance model. #5369

merged 2 commits into from
Mar 3, 2022

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Mar 1, 2022

Summary

Debugging production logs has been difficult without knowing the names of ended gameserver pods.
Added a column to the instance model to save the pod name.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@barankyle barankyle linked an issue Mar 1, 2022 that may be closed by this pull request
packages/gameserver/src/channels.ts Outdated Show resolved Hide resolved
Debugging production logs has been difficult without knowing the names of ended gameserver pods.
Added a column to the instance model to save the pod name.
@barankyle barankyle merged commit 8554c18 into dev Mar 3, 2022
@barankyle barankyle deleted the instance-pod-name branch March 3, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save gameserver pod name in instance table
2 participants