Project Configurable Env Settings #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
requested review from
speigg and
barankyle
and removed request for
speigg
speigg
approved these changes
Mar 14, 2022
| } | ||
|
|
||
| export const state = createState({ | ||
| projectSetting: [] as Array<ProjectSettingValue> |
There was a problem hiding this comment.
this state can just be an array, e.g.,
createState([] as Array<ProjectSettingValue>)| export interface ProjectSettingSchema { | ||
| key: string | ||
| type: string | ||
| scopes: Array<string> |
There was a problem hiding this comment.
type/scopes properties not being used anywhere?
There was a problem hiding this comment.
this will be used when we start adding code to check whether a person has access to any project setting or not
HexaField
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add project settings seeded from xrengine.config.ts of each project and allow updating from Admin Panel Settings
This PR will add a column to Project Table named
settingswhich can store and array of objects ({key: "", value: ""}). The key is the name of the setting and value can consist of any any string value you want stored against it.The Admin Panel will have a
Project Tabin/settingsroute now which will show settings config loaded from xrengine.config.ts , which then can be updated and stored in the database against each project.By default the Settings column of Project Table will be hidden from
project servicebut can be accessed throughproject-settings servicelike its used in the admin panel routes. Only admins currently have access to these api but later scopes can be used to allow fetching them according to the scehma available with each project.Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
#5183
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR