Fixed fetching of current closest users and their media. #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
requested changes
Mar 5, 2022
| }, | ||
| { | ||
| type: 'PRE_RENDER', | ||
| systemModulePromise: import('@xrengine/engine/src/networking/systems/MediaStreamSystem') |
There was a problem hiding this comment.
we should add this back to initializeRealitmeSystems in initialiseEngine.ts along with the conditional argument
speigg
approved these changes
Mar 6, 2022
barankyle
force-pushed
the
enable-media-stream-system-client
branch
from
0358382
to
a7bb64b
Compare
MediaStreamService had been disabled on the client. Re-enabled it, and made pause/resume producer/consumer functions push their actions to mediasoupOperationQueue. Moved initialization of MediaStreamSystem back to initializeEngine:initializeRealtimeSystems() from initializeMediaServerSystem and restored 'media' input parameter. gameserver/channels.ts now calls initializeRealtimeSystems(true, false) if in channel mode. Complete split of world and media servers had resulted in WebRTCRequestCurrentProducers message being sent to world server, which has no knowledge of producers. Added a new MediaStreamSystem message `TRIGGER_REQUEST_CURRENT_PRODUCERS`; the world server now gets the closest users and sends them with that message, with the media server setup adding a listener to take that list and call RequestCurrentProducers from the media server. With new hookstate implementation, updated PartyVideoWindows to properly use nearbyLayerUsers to populate PartyParticipantWindows.
barankyle
force-pushed
the
enable-media-stream-system-client
branch
from
a7bb64b
to
d4a0a76
Compare
HexaField
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MediaStreamService had been disabled on the client. Re-enabled it, and made pause/resume
producer/consumer functions push their actions to mediasoupOperationQueue.
Complete split of world and media servers had resulted in WebRTCRequestCurrentProducers message
being sent to world server, which has no knowledge of producers. Added a new MediaStreamSystem
message
TRIGGER_REQUEST_CURRENT_PRODUCERS; the world server now gets the closest users andsends them with that message, with the media server setup adding a listener to take that list
and call RequestCurrentProducers from the media server.
With new hookstate implementation, updated PartyVideoWindows to properly use nearbyLayerUsers
to populate PartyParticipantWindows.
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR