Fixed some bugs with authentication settings. #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
changed the title
Discord key/secret in client page were mistakenly changing Facebook values. Improved patching of authentication settings to handle enabling of not-previously-enabled providers. One, providers with non-settable oauth fields like `scope` were not having that inserted into the oauth settings; two, callback URLs for newly-enabled providers were not being set in the callback settings. authentication-setting patch() now iterates over all the providers in the patch data and adds scope/custom_data to the oauth entry if present in the the config for that provider, and adds a callback URL for it from the config as well.
barankyle
force-pushed
the
oauth-settings-fixes
branch
from
c2ccf2b
to
f86e6c0
Compare
zulqarnainhanif
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discord key/secret in client page were mistakenly changing Facebook values.
Improved patching of authentication settings to handle enabling of not-previously-enabled
providers. One, providers with non-settable oauth fields like
scopewere not having thatinserted into the oauth settings; two, callback URLs for newly-enabled providers were not
being set in the callback settings. authentication-setting patch() now iterates over all the
providers in the patch data and adds scope/custom_data to the oauth entry if present in the
the config for that provider, and adds a callback URL for it from the config as well.
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR