XRUI interactable modal improvements #5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speigg
changed the title
HexaField
approved these changes
Mar 5, 2022
| @@ -33,6 +44,36 @@ export default async function AnimationSystem(world: World) { | |||
| return () => { | |||
| const { delta } = world | |||
|
|
|||
| for (const entity of desiredTransformQuery(world)) { | |||
There was a problem hiding this comment.
i like this change, maybe we can rename DesiredTransformComponent to something more descriptive, something like AnimateLerpToTransformQuery maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various improvements to interactable modal XRUI
NOTE: includes elements that are highly targeted to an e-commerce use-case; this modal will eventually need to be generalized and made more customizable , or else will need to be designated as an e-commerce oriented UI.
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR