Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obstacles positioned incorrectly #5423

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Fix obstacles positioned incorrectly #5423

merged 2 commits into from
Mar 6, 2022

Conversation

HexaField
Copy link
Member

Summary

A summary of changes being made in this PR

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField requested a review from hamzzam March 5, 2022 23:44
@HexaField HexaField changed the title fix bug in gltf ecs loader Fix obstacles positioned incorrectly Mar 5, 2022
@HexaField HexaField marked this pull request as draft March 5, 2022 23:51
@HexaField HexaField marked this pull request as ready for review March 6, 2022 00:45
@HexaField HexaField merged commit 0059392 into dev Mar 6, 2022
@HexaField HexaField deleted the scene-loader-bug-fix branch March 6, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants