-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a minimalist mode with some show/hide buttons on location UI #5436
Conversation
…efactor-buttons
…Engine into refactor-buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The state of the button should be saved to local browser data, such that when i reload the page it remembers whether i left it shown or hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close, when the panels are hidden, they should also move in the opposite way to when they are shown, moving up or down. it also seems a bit slow, it should happen much faster, the same timing as the buttons rotating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- video, audio & face tracking automatically start without being clicked
- on mobile the screen is unclickable except for the middle third, the section holding all the media icons and settings icons is being clicked instead, this should click through to the canvas
- thumbpad to move is overlapping with the settings icons
- if the fullscreen button is not available, the refresh should sit over to the left so it looks right
- avatar thumbnail in top right can be made half the size
…efactor-buttons
Summary
A summary of changes being made in this PR
Clean up buttons
Added animations and auto-hide
Tested and enabled media button by default
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
References to pertaining issue(s)
QA Steps
git checkout pr_branch_name
npm install
npm run dev-reinit
npm run dev
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR