Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minimalist mode with some show/hide buttons on location UI #5436

Merged
merged 26 commits into from
Mar 24, 2022

Conversation

FabriceIRANKUNDA
Copy link
Contributor

@FabriceIRANKUNDA FabriceIRANKUNDA commented Mar 8, 2022

Summary

A summary of changes being made in this PR
Clean up buttons
Added animations and auto-hide
Tested and enabled media button by default

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@FabriceIRANKUNDA FabriceIRANKUNDA marked this pull request as ready for review March 10, 2022 13:50
@FabriceIRANKUNDA FabriceIRANKUNDA linked an issue Mar 14, 2022 that may be closed by this pull request
@HexaField
Copy link
Member

Screenshot from 2022-03-15 12-14-25

Mobile needs improvement.

@HexaField
Copy link
Member

Screenshot from 2022-03-15 12-15-47
bothbuttons need to be moved to the right a bit, such that the distance between the edge of the screen and the button are the same on both sides

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state of the button should be saved to local browser data, such that when i reload the page it remembers whether i left it shown or hidden.

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close, when the panels are hidden, they should also move in the opposite way to when they are shown, moving up or down. it also seems a bit slow, it should happen much faster, the same timing as the buttons rotating.

@HexaField HexaField self-requested a review March 18, 2022 08:45
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • video, audio & face tracking automatically start without being clicked
  • on mobile the screen is unclickable except for the middle third, the section holding all the media icons and settings icons is being clicked instead, this should click through to the canvas
  • thumbpad to move is overlapping with the settings icons
  • if the fullscreen button is not available, the refresh should sit over to the left so it looks right
  • avatar thumbnail in top right can be made half the size

@HexaField HexaField changed the title Refactor buttons Add a minimalist mode with some show/hide buttons on location UI Mar 18, 2022
@HexaField
Copy link
Member

Screenshot from 2022-03-22 14-12-26
please fix this

@HexaField HexaField merged commit 0f11a2d into dev Mar 24, 2022
@HexaField HexaField deleted the refactor-buttons branch March 24, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor buttons - Make buttons auto hide on location
2 participants