Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin panel should use login modal #5438

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Admin panel should use login modal #5438

merged 5 commits into from
Mar 10, 2022

Conversation

kimenyikevin
Copy link

@kimenyikevin kimenyikevin commented Mar 8, 2022 •
edited
Loading

Summary

A summary of changes being made in this PR

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@kimenyikevin kimenyikevin changed the title implemet logout for admin system Admin panel should use login modal Mar 8, 2022
@kimenyikevin kimenyikevin linked an issue Mar 9, 2022 that may be closed by this pull request
Admin panel should use login modal #5401
Closed
@kimenyikevin kimenyikevin marked this pull request as ready for review March 9, 2022 13:57
@zulqarnainhanif zulqarnainhanif merged commit e5fea4f into dev Mar 10, 2022
@zulqarnainhanif zulqarnainhanif deleted the improve-admin branch March 10, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zulqarnainhanif zulqarnainhanif zulqarnainhanif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin panel should use login modal
2 participants
@kimenyikevin @zulqarnainhanif