Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor light node fix #5556

Merged
merged 13 commits into from
Mar 25, 2022
Merged

Editor light node fix #5556

merged 13 commits into from
Mar 25, 2022

Conversation

NPatel10
Copy link
Contributor

@NPatel10 NPatel10 commented Mar 24, 2022

Summary

Fixed following lighting issue in this PR

  • Adding Point light in the editor is causing all the meshes to become invisible
  • Adding Spot light in the editor is causing all the meshes to become invisible
  • this binding for CSM method setupMaterial was wrong

Also worked on following issues as well

  • Selecting helper mesh with mouse is not working
  • Object 3d in the Scene hierarchy now has the same name as the NameComponent for better debugging.
  • Deleting/Grouping/Reparenting operation on last node in Hierarchy view panel is throwing error

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR
@HexaField @dinomut1

@NPatel10 NPatel10 mentioned this pull request Mar 24, 2022
8 tasks
@NPatel10 NPatel10 linked an issue Mar 24, 2022 that may be closed by this pull request
@NPatel10 NPatel10 merged commit 0f47b7d into dev Mar 25, 2022
@NPatel10 NPatel10 deleted the Editor-Light-node-fix branch March 25, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix real time lighting + shadow maps for point lights
2 participants