Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoplay and Media Component Improvements #7714

Merged
merged 4 commits into from
Mar 11, 2023
Merged

Autoplay and Media Component Improvements #7714

merged 4 commits into from
Mar 11, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Mar 9, 2023 •
edited

Summary

Replaces autoplay with paused on the MediaComponent

References

closes #7467
closes #7488

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField changed the title Autoplay and Media Component iIprovements Autoplay and Media Component Improvements Mar 9, 2023
@HexaField HexaField requested a review from speigg March 9, 2023 22:31
@HexaField HexaField marked this pull request as ready for review March 9, 2023 22:38
@HexaField HexaField marked this pull request as draft March 10, 2023 01:52
@speigg
Copy link
Member

speigg commented Mar 10, 2023

Seems to work great on Safari; just needs a few tests fixed!

@HexaField HexaField marked this pull request as ready for review March 11, 2023 08:12
@HexaField HexaField added this pull request to the merge queue Mar 11, 2023
Merged via the queue into dev with commit d416b90 Mar 11, 2023
@HexaField HexaField deleted the autoplay-improvements branch March 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speigg speigg speigg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Safari autoplay edge case Disable hark speaking colors while muted
2 participants
@HexaField @speigg