Fixed some bugs in cache flow #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running npm install from packages/projects was not correct. To just install projects' dependencies, we're now using a second root package.json that for workspaces only has the packages that the builder comes preinstalled with and packages/projects/projects/*. This ensures that all projects' dependencies are installed, all necessary packages for running the builder stay installed, and packages that are not necessary for root builder tasks are not installed unnecessarily. Dockerfile-root runs npm install; this had been commented out for testing purposes and mistakenly not uncommented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running npm install from packages/projects was not correct. To just install projects' dependencies, we're now using a second root package.json that for workspaces only has the packages that the builder comes preinstalled with and packages/projects/projects/*. This ensures that all projects' dependencies are installed, all necessary packages for running the builder stay installed, and packages that are not necessary for root builder tasks are not installed unnecessarily.
Dockerfile-root runs npm install; this had been commented out for testing purposes and mistakenly not uncommented.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.