Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create /chat page with existing social features #8195

Merged
merged 71 commits into from
Jul 27, 2023
Merged

Create /chat page with existing social features #8195

merged 71 commits into from
Jul 27, 2023

Conversation

mrhegemon
Copy link
Member

@mrhegemon mrhegemon commented Jun 27, 2023

Summary

FEATURES

This PR includes the following:

  • New /chat route using tailwind
  • New FeathersHooks utility for Reactive feathers requests and caching
  • replaces parties and groups with channels
  • media instance connection for world and channels unified

DATABASE MIGRATIONS

  • party, party_user, group, group_user, group_user_rank channel_type tables have been dropped
  • group:read group:write party:read party:write scopes have been replaced with channel:read and channel:write
  • channel_user table has been added
  • group and party invite types are now channel
  • group and party invite email subject fields collapsed into channel

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

  • ensure admin panel channels page works correctly, populating data and search query
  • ensure socials work, messaging friends and starting and ending media sessions with them

@HexaField HexaField changed the title Chat route Create /chat page with existing social features Jun 28, 2023
@speigg
Copy link
Member

speigg commented Jul 25, 2023

/chat route

  • page is not responsive, seems to have a fixed width
  • UI seems generally broken/buggy (pretty much nothing works? am I meant to be reviewing this route?)

/location route

  • Sometimes, sending a message does not show the message to the recipient immediately (have to exit the message window and return to see it, or send back a message to the other user, and then the previously received messages show up)
  • why does clicking on the chat icon next to the user in the "Friends" menu open up a group chat? Is there only one group chat shared between all your friends?
  • There are no user names in the group chat, no way to know who is saying what
  • layout / style of the chat window looks unpolished

@HexaField
Copy link
Member

/location route

  • Sometimes, sending a message does not show the message to the recipient immediately (have to exit the message window and return to see it, or send back a message to the other user, and then the previously received messages show up)
  • why does clicking on the chat icon next to the user in the "Friends" menu open up a group chat? Is there only one group chat shared between all your friends?
  • There are no user names in the group chat, no way to know who is saying what
  • layout / style of the chat window looks unpolished

All these location bugs have been fixed. The styling still could use some work, but we need this PR in for the added functionality ASAP.

@HexaField HexaField merged commit c43b98e into dev Jul 27, 2023
8 checks passed
@HexaField HexaField deleted the chat-route branch July 27, 2023 04:05
@xr-dev-saurabh xr-dev-saurabh mentioned this pull request Jul 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants