Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8152 file browser model preview doesnt work for glb #8239

Merged
merged 20 commits into from
Jul 18, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Jul 6, 2023

Summary

changed the function which loads model in the preview, it now works just fine

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@SYBIOTE SYBIOTE linked an issue Jul 6, 2023 that may be closed by this pull request
@SYBIOTE SYBIOTE marked this pull request as draft July 6, 2023 18:10
@SYBIOTE SYBIOTE self-assigned this Jul 6, 2023
@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 10, 2023

any update for this?

@SYBIOTE SYBIOTE marked this pull request as ready for review July 11, 2023 09:10
@HexaField HexaField merged commit 2022fd8 into dev Jul 18, 2023
8 checks passed
@HexaField HexaField deleted the 8152-file-browser-model-preview-doesnt-work-for-glb branch July 18, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File browser model preview doesn’t work for .glb
2 participants