Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TransformProperty): local transform component mode #8439

Merged
merged 11 commits into from Oct 20, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Aug 7, 2023

Summary

Added a boolean input to use LocalTranformComponent when the input is checked.

image

References

closes #8432

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works fine, but we cannot update transform properties on the TransformComponent the same way we do with LocalTransformComponent (via the gizmo), we need to compute and update the TransformComponent directly, or it has incorrect transformations applied and sometimes does not work, snapping back to the original position. We still need to update the gizmo accordingly

@HexaField HexaField force-pushed the feat/use-local-transform-component branch from 87edec0 to 6a830e6 Compare August 10, 2023 23:10
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the vector3 scrubbers in the properties panel when using non local transform resets all the values to 0

@speigg
Copy link
Member

speigg commented Aug 30, 2023

IMO we should always be editing the local transform by default, with an option to edit the world transform (by modifying the local transform behind the scenes).

@Griffisaurus Griffisaurus marked this pull request as draft October 19, 2023 22:26
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be rewritten to work with our new snapshots concept

Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works as intended after resolving merge conflicts

@dinomut1 dinomut1 marked this pull request as ready for review October 19, 2023 22:36
@HexaField HexaField merged commit 12a6533 into dev Oct 20, 2023
12 of 13 checks passed
@HexaField HexaField deleted the feat/use-local-transform-component branch October 20, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants