Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button capture to camera input system #8918

Conversation

DanielBelmes
Copy link
Contributor

@DanielBelmes DanielBelmes commented Sep 27, 2023

Summary

🤖 Generated by Copilot at 9524c22

This pull request improves the camera and interaction system by allowing the user to switch between camera mode and interaction mode using input source buttons. It also fixes a bug where link entities could be activated by a captured input source. The main files affected are CameraInputSystem.ts, AvatarInputSystem.ts, and LinkComponent.ts.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 9524c22

  • Add fallback logic to find input source entity for avatar interaction (link)

🤖 Generated by Copilot at 9524c22

capturedInputSource
switches camera and link modes
fall leaves flutter by

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@DanielBelmes
Copy link
Contributor Author

Added similar UX to the grabbable component. When hovering over the link component text will appear saying "Click to follow link." It will also scale up to a limit depending how far you are from it.

@DanielBelmes DanielBelmes marked this pull request as ready for review October 3, 2023 19:17
@HexaField HexaField requested a review from speigg October 15, 2023 23:44
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input flicks between xrui and object

@DanielBelmes DanielBelmes merged commit 875ad01 into dev Oct 31, 2023
13 checks passed
@DanielBelmes DanielBelmes deleted the 8620-refactor-camera-input-systems-to-integrate-with-spatial-input-system branch October 31, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor camera input systems to integrate with spatial input system
3 participants