Changes for match-ticket, match-ticket-assignment services hook refactor #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzlamateen
requested changes
Oct 18, 2023
| import { | ||
| matchTicketDataResolver, | ||
| matchTicketExternalResolver, | ||
| matchTicketQueryResolver, | ||
| matchTicketResolver | ||
| } from './match-ticket.resolvers' | ||
|
|
||
| const ensureId = async (context: HookContext<MatchTicketService>) => { | ||
| if (typeof context.id !== 'string' || context.id.length === 0) { |
There was a problem hiding this comment.
You can use disallow-non-id.ts. Search for disallowNonId in our code
hanzlamateen
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
馃 Generated by Copilot at 7180bc4
The pull request refactors the matchmaking services and hooks for match tickets and match ticket assignments, using the
KnexServicebase class and helper functions to simplify the code and avoid duplication. It also removes unnecessary arguments from the service constructors and updates the imports accordingly.References
#8871
Explanation
馃 Generated by Copilot at 7180bc4
KnexServiceinMatchTicketServiceandMatchTicketAssignmentServiceclasses (link, link, link, link)MatchTicketAssignmentServiceclass togetTicketAssigmentfunction inmatch-ticket-assignment.hooks.ts(link, link, link)appargument fromMatchTicketAssignmentServiceconstructor inmatch-ticket-assignment.ts(link)MatchTicketServiceclass toensureId,getEmulationTicket,createInEmulation, andskipDeleteInEmulationfunctions inmatch-ticket.hooks.ts(link, link, link, link)appargument fromMatchTicketServiceconstructor inmatch-ticket.ts(link)match-ticket-assignment.hooks.tsandmatch-ticket.hooks.tsto add or remove modules as needed (link, link, link)馃 Generated by Copilot at 7180bc4
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist