Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-spline-component #9037

Merged
merged 2 commits into from Oct 15, 2023
Merged

fix-spline-component #9037

merged 2 commits into from Oct 15, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Oct 11, 2023

Summary

馃 Generated by Copilot at a166595

Improved the performance and code quality of spline editing components in the editor package. Used NO_PROXY to avoid unnecessary reactivity for SplineComponent.elements, and ensured proper type conversion for position and quaternion properties. Removed unused and redundant code from SplineTrackNodeEditor.tsx.

References

closes #insert number here

Explanation

馃 Generated by Copilot at a166595

  • Imported NO_PROXY symbol to access raw values of reactive properties without triggering reactivity (link)
  • Used get method with NO_PROXY argument to avoid reactive dependency on elements array of SplineComponent (link, link)
  • Converted input values to Vector3 and Quaternion instances before updating position and quaternion properties of SplineComponent (link, link)
  • Removed unused onChange and onRelease functions from SplineTrackNodeEditor component (link, link)
  • Replaced onChange and onRelease handlers with commitProperty function to update velocity property of SplineTrackComponent (link)

馃 Generated by Copilot at a166595

Sing, O Muse, of the skillful coder who refined the SplineNodeEditor
And made it faster and more accurate, avoiding the reactive error
By using the NO_PROXY symbol, a cunning trick of the mind
To manipulate the elements array, as the gods themselves designed

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField merged commit f7b552e into dev Oct 15, 2023
13 checks passed
@HexaField HexaField deleted the spline-node-fix branch October 15, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants