Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to use scope type service instead of seedFile object #9044

Merged
merged 1 commit into from Oct 13, 2023

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Oct 12, 2023

Summary

馃 Generated by Copilot at 539ac5a

Refactored the identity provider and initial admin creation logic to use the scope type service instead of a static seed file. This improves the modularity and configurability of the engine schema.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 539ac5a

  • Replaced scopeTypeSeed import with scopeTypePath import from engine schema in identity-provider.class.ts and make-initial-admin.ts (link, link)
  • Updated logic for adding all scopes to the first user made an admin in dev mode to use scopeTypePath service instead of scopeTypeSeed array in identity-provider.class.ts and make-initial-admin.ts (link, link)

馃 Generated by Copilot at 539ac5a

No more seeds of static scope
We unleash the dynamic mode
scopeTypeService is our guide
We defy the engine's code

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@barankyle barankyle added this pull request to the merge queue Oct 13, 2023
Merged via the queue into dev with commit c527664 Oct 13, 2023
14 checks passed
@barankyle barankyle deleted the scope-type-service branch October 13, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants