Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hand tracking through screen landmarks #9050

Merged
merged 2 commits into from Oct 16, 2023

Conversation

DanielBelmes
Copy link
Contributor

@DanielBelmes DanielBelmes commented Oct 13, 2023

I did try using the wrist to thumb vector to detect hand orientation more fine grain. Apparently media pipe does a killer job with the vector positions and the plane used in hand tracking has a perfectly good normal.

Fixed a bug I was seeing causing the capture page to crash in the capture pages header.

Summary

🤖 Generated by Copilot at 3329a56

This pull request fixes a bug in the hand pose alignment for motion capture and adds a safety check for the user avatar details in the UI. It modifies solveMotionCapturePose.ts and Header/index.tsx in the engine and ui packages respectively.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 3329a56

  • Fix hand pose alignment bug by using screen coordinates instead of original landmarks in solveHand calls (link, link) in solveMotionCapturePose.ts

🤖 Generated by Copilot at 3329a56

Oh we're the coders of the sea, we write the code that makes it be
We fix the bugs and add the features, we make the UI look so neat
We use the ?. operator, to avoid the errors that might occur
And we align the hand pose right, with screenlandmarks in our sight

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@DanielBelmes DanielBelmes merged commit 61b9328 into mocap-solve-improvements Oct 16, 2023
2 checks passed
@DanielBelmes DanielBelmes deleted the mocap-solve-hand branch October 16, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants