Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

save was being blocked if effects were turned off #9053

Merged
merged 1 commit into from Oct 13, 2023
Merged

Conversation

anselm
Copy link
Collaborator

@anselm anselm commented Oct 13, 2023

Summary

馃 Generated by Copilot at 5033f01

Fixed screenshot errors and selection loss in editor. Improved takeScreenshot.ts code with optional chaining.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 5033f01

  • Prevent errors and crashes when taking a screenshot with the highlight effect disabled or the hide helpers option enabled (link, link)

馃 Generated by Copilot at 5033f01

When taking a screenshot with code
You don't want to lose your selection mode
So HighlightEffect got some checks
With optional chaining syntax
To fix issue #113 and lighten the load

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@speigg speigg added this pull request to the merge queue Oct 13, 2023
Merged via the queue into dev with commit 1596d02 Oct 13, 2023
13 of 14 checks passed
@speigg speigg deleted the highlight-save branch October 13, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants