Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Static Resources #9061

Merged
merged 4 commits into from Oct 18, 2023
Merged

Simplify Static Resources #9061

merged 4 commits into from Oct 18, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Oct 16, 2023

Summary

馃 Generated by Copilot at fd87665

This pull request removes unused and deprecated code related to static resources, audio uploads, and scene files from the server-core package. It also refactors and improves the logic for handling static resources from different domains and projects, and disables the cloning of external resources by default. It updates the configuration files and the logging system accordingly.

References

closes #8629

Explanation

馃 Generated by Copilot at fd87665

  • Remove the cloning of static resources from external URLs by default, and make it an optional argument for the functions that need it (link, link, link)
  • Simplify the logic for checking whether an asset is from the same domain as the storage provider, and avoid unnecessary duplication of assets across projects (link, link, link, link)
  • Remove the deprecated audio-upload feature and its related functions and tests from static-resource-helper.ts and scene-helper.ts (link, link)
  • Remove unused imports from various helper and test files (link, link, link, link)
  • Improve the logging quality and consistency in upload-asset.service.ts by using the logger object and formatting the arguments (link, link, link)

馃 Generated by Copilot at fd87665

Sing, O Muse, of the valiant code review
That cleansed the server-core of obsolete code
And tamed the cloning of static resources
By CLONE_STATIC_RESOURCES's wise abode

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField marked this pull request as ready for review October 16, 2023 05:30
@HexaField HexaField merged commit 22ce891 into dev Oct 18, 2023
13 checks passed
@HexaField HexaField deleted the simplify-static-resources branch October 18, 2023 02:24
HexaField added a commit that referenced this pull request Oct 18, 2023
* simplify static resource parsing of scenes and uploads

* add download button in file browser input

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework static-resource uploads
2 participants