Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Loading Screen State #9070

Merged
merged 3 commits into from Oct 17, 2023
Merged

Rework Loading Screen State #9070

merged 3 commits into from Oct 17, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Oct 17, 2023

Summary

馃 Generated by Copilot at 59ba572

This pull request simplifies and optimizes the loading UI and user avatar logic by using a new userReady property in the EngineState. It removes unused code and imports from several files, and updates the LoadingUISystem.tsx and CameraSystem.tsx files to use the userReady property to handle loading transitions.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 59ba572

  • Added userReady property to EngineState to track user avatar and camera loading (link)
  • Removed metadataLoaded property from LoadingUISystemState and replaced it with userReady and sceneLoaded from EngineState (link, link)
  • Set userReady to true in loadAvatarForUser function if entity is localClientEntity (link)
  • Set userReady to true in CameraSystem after camera initialization (link)
  • Removed unused imports of EngineActions, defineActionQueue, and dispatchAction from various files (link, link, link)
  • Removed unused definitions of avatarModelChangedQueue, spectateUserQueue, and avatarModelChanged action from various files (link, link, link)
  • Removed irrelevant comment from LoadingUISystem.tsx (link)

馃 Generated by Copilot at 59ba572

userReady flag
signals camera and avatar
spring of loading done

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField merged commit 9bfae4b into dev Oct 17, 2023
10 of 12 checks passed
@HexaField HexaField deleted the loading-ui branch October 17, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants