New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace play mode with isEditing state #9071
Conversation
I did test this branch and I do still see the same reset issue... basically it's just that if I do the following I get unexpected behavior:
The artifact moves when I hit pause. |
That's a different issue with the gizmo not creating snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great we can now make editor specific features, directly in the engine package, a welcome change as the engine doesn't reference the editor,
we should look over the code base where we use .isinPlaymode, in the components
and migrate those as well to avoid errors
Ok, but this is why I didn't push a similar change earlier. I'm happy however with decoupling these issues. I think we should get this in and I tested it and it works fine otherwise. |
Oh there's a small bug in the test suites in general - with .scss being passed to a javascript compiler - so everything is failing tests. |
Summary
馃 Generated by Copilot at fdce981
Refactored the editor and engine state to use a new
isEditing
property to track the play mode status. Added a feature to save and restore the scene state using the history state when switching between play and edit modes. Removed or deprecated unused or redundant properties from the state schemas.References
closes #insert number here
Explanation
馃 Generated by Copilot at fdce981
馃 Generated by Copilot at fdce981
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist