Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate cert authority #9072

Merged
merged 5 commits into from Oct 24, 2023
Merged

Automate cert authority #9072

merged 5 commits into from Oct 24, 2023

Conversation

ashish-aesthisia
Copy link
Contributor

@ashish-aesthisia ashish-aesthisia commented Oct 17, 2023

Summary

🤖 Generated by Copilot at 3c9070c

The pull request adds a feature that enables HTTPS support for the Ethereal Engine web app. It modifies the dev-docker script to generate and install a self-signed certificate using a custom configuration file (openssl.cnf) for the openssl command.

References

closes #9009

Explanation

🤖 Generated by Copilot at 3c9070c

  • Enable HTTPS support for the web app by generating and installing a self-signed certificate (link, link, link)
  • Modify the dev-docker script in package.json to run the generate-certs.sh script after starting the containers (link)
  • Modify the generate-certs.sh script in the scripts folder to use a custom configuration file (openssl.cnf) for the openssl command (link)
  • Add the openssl.cnf file to the scripts folder with the values for the certificate fields (link)

🤖 Generated by Copilot at 3c9070c

dev-docker runs
generate-certs.sh script
HTTPS in winter

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@cla-bot
Copy link

cla-bot bot commented Oct 17, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Oct 17, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

scripts/build_minikube.sh Show resolved Hide resolved
scripts/generate-certs.sh Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Oct 18, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hanzlamateen
Copy link
Member

Can you explain, where in our deployment for microk8s/minikube we are specifying the certificates that are generated in /generate-certs.sh?

@ashish-aesthisia
Copy link
Contributor Author

Can you explain, where in our deployment for microk8s/minikube we are specifying the certificates that are generated in /generate-certs.sh?

I checked this but there is no separate implementation related to minikube or microk8s for certs. I think they are directly being used from the filesys. As env.default.local also has the paths
Screenshot 2023-10-24 at 7 47 41 AM

@cla-bot
Copy link

cla-bot bot commented Oct 24, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hanzlamateen
Copy link
Member

Can you explain, where in our deployment for microk8s/minikube we are specifying the certificates that are generated in /generate-certs.sh?

I checked this but there is no separate implementation related to minikube or microk8s for certs. I think they are directly being used from the filesys. As env.default.local also has the paths Screenshot 2023-10-24 at 7 47 41 AM

Have you tested this local certificate thing is working fine for minikube & microk8s?

@hanzlamateen
Copy link
Member

Got this error in CC

8:54:31 AM: configure microk8s - ./scripts/build_microk8s.sh: line 120: ./generate-certs.sh: No such file or directory
8:54:31 AM: configure microk8s - "Failed with error code 1."
8:54:31 AM: configure cluster - "Failed with error code 1."

XRE-b86025e1-657e-4f90-8698-3c7dfe7f3b79-2023-10-24T04-04-19.705Z.txt

@ashish-aesthisia
Copy link
Contributor Author

Got this error in CC

8:54:31 AM: configure microk8s - ./scripts/build_microk8s.sh: line 120: ./generate-certs.sh: No such file or directory
8:54:31 AM: configure microk8s - "Failed with error code 1."
8:54:31 AM: configure cluster - "Failed with error code 1."

XRE-b86025e1-657e-4f90-8698-3c7dfe7f3b79-2023-10-24T04-04-19.705Z.txt

Let me try this once more

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work across all environments? linux, mac, windows?

@HexaField HexaField merged commit 6db8c85 into dev Oct 24, 2023
10 of 13 checks passed
@HexaField HexaField deleted the bugFix/9009-automate-cert-authority branch October 24, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup automatic certificate authority for HTTPS
3 participants