Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

search by owner in avatars table #9073

Merged
merged 7 commits into from Oct 25, 2023
Merged

search by owner in avatars table #9073

merged 7 commits into from Oct 25, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 17, 2023

Summary

Instead of userId being shown previously in the owner column, we will now show the user.name

image

馃 Generated by Copilot at 6f39fc7

Refactored the admin avatar table component and added a custom hook to the avatar service. This enables sorting avatars by user name in the admin interface, and simplifies the data creation logic. Affected files are AvatarTable.tsx and avatar.hooks.ts.

References

closes #8929

Explanation

馃 Generated by Copilot at 6f39fc7

  • Added a custom hook to sort avatars by user name (link, link)
  • Simplified the data creation function for the avatar table component (link)
  • Removed an unused type import from the avatar table component (link)

馃 Generated by Copilot at 6f39fc7

Sing, O Muse, of the skillful coder who refactored
The avatar table, that splendid display of faces divine,
And who added a hook, addAndSortByUserName, to order
The avatars by name, as Zeus arranges the stars that shine.

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aditya-mitra aditya-mitra added this pull request to the merge queue Oct 25, 2023
Merged via the queue into dev with commit 4d6ba78 Oct 25, 2023
12 of 13 checks passed
@aditya-mitra aditya-mitra deleted the fix/avatars-table-owner branch October 25, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Owner' not valid search for avatars
2 participants