New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
search by owner in avatars table #9073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzlamateen
requested changes
Oct 18, 2023
hanzlamateen
requested changes
Oct 22, 2023
hanzlamateen
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of
userId
being shown previously in the owner column, we will now show theuser.name
馃 Generated by Copilot at 6f39fc7
Refactored the admin avatar table component and added a custom hook to the avatar service. This enables sorting avatars by user name in the admin interface, and simplifies the data creation logic. Affected files are
AvatarTable.tsx
andavatar.hooks.ts
.References
closes #8929
Explanation
馃 Generated by Copilot at 6f39fc7
馃 Generated by Copilot at 6f39fc7
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist