Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skeleton helper #9078

Merged
merged 1 commit into from Oct 18, 2023
Merged

Fix skeleton helper #9078

merged 1 commit into from Oct 18, 2023

Conversation

DanielBelmes
Copy link
Contributor

@DanielBelmes DanielBelmes commented Oct 17, 2023 •
edited

Remap a bone name to hips so that skeletonHelper works.

#9079

Explanation

馃 Generated by Copilot at da3d164

  • Add a fallback mapping for bones that are not found in the mixamoVRMRigMap (link)
  • Define the hipRigMap object in packages/engine/src/avatar/AvatarBoneMatching.ts (link)

馃 Generated by Copilot at da3d164

We're sailing on the virtual sea, with avatars of all kinds
But some of them are out of sync, their bones don't match their minds
So we need a fallback map, for those who use Mixamo
We'll align them with the VRM, and make them good to go

@HexaField HexaField merged commit 3044263 into dev Oct 18, 2023
12 of 14 checks passed
@HexaField HexaField deleted the fixskeletonhelper branch October 18, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanCaruso AidanCaruso AidanCaruso approved these changes

@speigg speigg Awaiting requested review from speigg

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielBelmes @AidanCaruso @HexaField