Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

close menu after confirming avatar #9090

Merged
merged 5 commits into from Oct 23, 2023
Merged

close menu after confirming avatar #9090

merged 5 commits into from Oct 23, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 19, 2023

Summary

create avatar through readyplayer was working fine

馃 Generated by Copilot at d98dbe7

Added a popup menu for avatar selection in the user menu. The popup menu is triggered by clicking on the avatar icon and uses the showPopupMenu method of the PopupMenuServices class.

References

closes #9049

Explanation

馃 Generated by Copilot at d98dbe7

  • Show a popup menu of avatars when the user clicks on the avatar icon in the user menu (AvatarSelectMenu.tsx, link)

馃 Generated by Copilot at d98dbe7

Click on avatar
showPopupMenu appears
Autumn of choices

QA Steps

11f8934e-b140-40c3-b5d4-3ca31dbcd2c6

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than just closing the menu, we should add a spinner over the Confirm button until the avatar has loaded (can react to EngineState userReady)

@HexaField
Copy link
Member

Rather than just closing the menu, we should add a spinner over the Confirm button until the avatar has loaded (can react to EngineState userReady)

#9097

this PR might be necessary to make this work properly

@HexaField HexaField merged commit 565e041 into dev Oct 23, 2023
12 of 13 checks passed
@HexaField HexaField deleted the fix/confirm-avatar-menu branch October 23, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Selecting an avatar no longer closes the menu on mobile
2 participants