Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opaque typings, InstanceID enforced #7094 #9095

Merged
merged 1 commit into from Oct 20, 2023
Merged

Opaque typings, InstanceID enforced #7094 #9095

merged 1 commit into from Oct 20, 2023

Conversation

AmadeusMoon
Copy link
Contributor

@AmadeusMoon AmadeusMoon commented Oct 19, 2023 •
edited

Summary

  • InstanceID opaque type enforced where possible on instanceId

References

#7094

Checklist

✅Ran engine no noticeable errors found to be caused
❌Ran npm check 1 test failed at s3.storage.ts

@HexaField HexaField self-requested a review October 19, 2023 22:47
@AmadeusMoon AmadeusMoon deleted the dev-7094 branch October 20, 2023 01:14
@AmadeusMoon AmadeusMoon restored the dev-7094 branch October 20, 2023 01:14
@AmadeusMoon AmadeusMoon reopened this Oct 20, 2023
@AmadeusMoon
Copy link
Contributor Author

Oopsies I wanted to just rename the branch I had no idea it would close the PR 😢

@HexaField HexaField merged commit 3c90212 into EtherealEngine:dev Oct 20, 2023
22 of 24 checks passed
@AmadeusMoon AmadeusMoon deleted the dev-7094 branch October 20, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanCaruso AidanCaruso AidanCaruso approved these changes

@HexaField HexaField Awaiting requested review from HexaField

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmadeusMoon @AidanCaruso @HexaField