Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelId #9099

Merged
merged 2 commits into from Oct 20, 2023
Merged

ChannelId #9099

merged 2 commits into from Oct 20, 2023

Conversation

AmadeusMoon
Copy link
Contributor

Summary

  • ChannelID was already set everywhere except 1 single instance.

References

#7094

@AmadeusMoon
Copy link
Contributor Author

I didn't know if I should just push this 1 irrelevant change to the other branch but in the end I decided to simply make it a tinny PR. Also the test commit was because I was fixing some type errors that showed up during the npm run test.
It seemed that I was fixing type errors in featherjs and I did not realize I was trying to commit changes to node_module. 😢

@HexaField HexaField merged commit 125f7ae into EtherealEngine:dev Oct 20, 2023
12 of 13 checks passed
@AmadeusMoon AmadeusMoon deleted the channelId branch October 20, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmadeusMoon @HexaField