New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primitive-geometry-in-editor #9107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinomut1
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dragging and dropping the component into the scene creates a blank node with no PrimitiveGeometryComponent
EDIT: This is an issue with all components at the moment nevermind
dinomut1
approved these changes
Oct 23, 2023
Seems to work well for me. |
speigg
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
馃 Generated by Copilot at b7429ee
This pull request adds a new
PrimitiveGeometryComponent
to the engine and the editor packages, which enables users to create and edit basic shapes in the scene. It also adds translations for the component and its node editor in theeditor.json
file. It modifies theElementList.tsx
andComponentEditors.tsx
files to integrate the component and its node editor in the editor UI. It creates new filesPrimitiveGeometryComponent.ts
,PrimitiveGeometryNodeEditor.tsx
, andGeometryTypeEnum.ts
to define the component, the node editor, and the geometry type enum.References
closes #insert number here
Explanation
馃 Generated by Copilot at b7429ee
馃 Generated by Copilot at b7429ee
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist