Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive-geometry-in-editor #9107

Merged
merged 9 commits into from Oct 23, 2023
Merged

Primitive-geometry-in-editor #9107

merged 9 commits into from Oct 23, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Oct 20, 2023

Summary

馃 Generated by Copilot at b7429ee

This pull request adds a new PrimitiveGeometryComponent to the engine and the editor packages, which enables users to create and edit basic shapes in the scene. It also adds translations for the component and its node editor in the editor.json file. It modifies the ElementList.tsx and ComponentEditors.tsx files to integrate the component and its node editor in the editor UI. It creates new files PrimitiveGeometryComponent.ts, PrimitiveGeometryNodeEditor.tsx, and GeometryTypeEnum.ts to define the component, the node editor, and the geometry type enum.

References

closes #insert number here

Explanation

馃 Generated by Copilot at b7429ee

馃 Generated by Copilot at b7429ee

Oh, we are the coders of the sea
We make the shapes that you can see
With PrimitiveGeometryComponent
We heave and ho and count to three

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@dinomut1 dinomut1 self-requested a review October 23, 2023 14:52
Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dragging and dropping the component into the scene creates a blank node with no PrimitiveGeometryComponent
EDIT: This is an issue with all components at the moment nevermind

@anselm
Copy link
Collaborator

anselm commented Oct 23, 2023

Seems to work well for me.

@speigg speigg added this pull request to the merge queue Oct 23, 2023
Merged via the queue into dev with commit 658b83e Oct 23, 2023
12 of 13 checks passed
@speigg speigg deleted the primitive-geometry-in-editor branch October 23, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants