New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AR, Camera Mode and Scene Scale Fixes #9117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
changed the title
AR Camera Mode and Scene Scale Fixes
Mobile AR Camera Mode and Scene Scale Fixes
Oct 22, 2023
Pushed a one liner to fix the head occluding view in webxr |
When testing in my Quest there still seems to be something preventing the head decap component from working the first time I enter immersive mode. Restarting immersive webxr in the same session it works fine. I cannot reproduce this behavior with the emulator. |
HexaField
changed the title
Mobile AR Camera Mode and Scene Scale Fixes
AR, Camera Mode and Scene Scale Fixes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
userEyeLevel
anduserAvatarHeightDifference
intouserAvatarHeightScale
🤖 Generated by Copilot at 4aec1a7
This pull request enhances the XR support for the avatar system and the touch gamepad component. It introduces new modules
XRControlsState
andXRState
to handle the scaling and camera modes for XR devices. It also fixes some issues with the avatar IK and movement functions, and imports theAvatarHeadDecapComponent
for the avatar animation system.References
closes #9109
closes #7670
Explanation
🤖 Generated by Copilot at 4aec1a7
AvatarAnimationSystem.ts
to mark avatars with decapitated heads (link)🤖 Generated by Copilot at 94d761e
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist