Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled use of client pagination in FeathersHook useFind #9128

Merged
merged 1 commit into from Oct 24, 2023

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Oct 24, 2023

Summary

Since we can enable paginate:false for certain services using enableClientPagination hook on server end. But there was an issue in FeathersHook on client as it was appending those pagination limit, step, etc variables which was overriding the request to not handle paginate: false.

馃 Generated by Copilot at ebdd973

Modified useFind hook to support non-paginated queries. The hook now checks the query parameters for paginate or $paginate flags and passes them to the useService hook accordingly.

References

closes #insert number here

Explanation

馃 Generated by Copilot at ebdd973

  • Modify useFind hook to handle non-paginated queries (link)

馃 Generated by Copilot at ebdd973

useFind respects
paginate query option
no more wasted calls

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@hanzlamateen hanzlamateen merged commit a6b01d7 into dev Oct 24, 2023
12 of 14 checks passed
@hanzlamateen hanzlamateen deleted the usefind-client-pagination branch October 24, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants