Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix studio tooltip keys #9131

Merged
merged 2 commits into from Oct 24, 2023
Merged

fix studio tooltip keys #9131

merged 2 commits into from Oct 24, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Oct 24, 2023

Summary

馃 Generated by Copilot at 146ced2

The jsonID values of some engine components were changed to use hyphens instead of camel case, and the tooltip keys in the editor were updated accordingly. This improves the consistency and maintainability of the component naming and localization.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 146ced2

  • Changed the jsonID values of BehaveGraphComponent and EnvMapBakeComponent to follow the same convention as the other components and match the tooltip keys in the editor (link, link)
  • Updated the tooltip keys for the editor components in packages/client-core/i18n/en/editor.json to match the jsonID values of the corresponding components in the engine (link)

馃 Generated by Copilot at 146ced2

jsonID values
aligned with tooltip keys
autumn cleaning code

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the JSON ids needs a migration script or they will not load, need to revert them

@HexaField HexaField merged commit 1d3a920 into dev Oct 24, 2023
10 of 12 checks passed
@HexaField HexaField deleted the fix-element-list-tooltips branch October 24, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants