Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Sitting #9148

Merged
merged 31 commits into from Nov 11, 2023
Merged

Avatar Sitting #9148

merged 31 commits into from Nov 11, 2023

Conversation

AidanCaruso
Copy link
Member

@AidanCaruso AidanCaruso commented Oct 25, 2023

Summary

馃 Generated by Copilot at d670056

This pull request adds and updates features related to avatar seating and animation in the engine and the editor. It enables the MountPointComponent in the ElementList UI, improves the network and bounding box handling of the MountPointSystem, fixes a bug in the updateAnimationGraph function, and adds a new seated animation state to the animationStates object.

References

closes #insert number here

Explanation

馃 Generated by Copilot at d670056

  • Import and add MountPointComponent to the ElementList component to enable editing mount points in the editor (link, link)
  • Fix a bug in the updateAnimationGraph function that caused incorrect fadingOut flag for animations that need to skip the transition (link)
  • Add a new animation state called seated to the animationStates object for avatars (link)
  • Refactor the MountPointSystem module to handle the mounting and unmounting logic of avatars and mount points (link, link, link, link, link, link)

馃 Generated by Copilot at d670056

Oh we're the crew of the MountPointComponent
We make the seats for the avatars to sit
We fix the bugs in the updateAnimationGraph
And we heave away on the count of three

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@AidanCaruso AidanCaruso changed the title Sitting Avatar Sitting Oct 25, 2023
@AidanCaruso AidanCaruso marked this pull request as ready for review November 3, 2023 00:41
@AidanCaruso AidanCaruso marked this pull request as draft November 6, 2023 22:39
@AidanCaruso AidanCaruso marked this pull request as ready for review November 8, 2023 23:00
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@AidanCaruso AidanCaruso added this pull request to the merge queue Nov 11, 2023
Merged via the queue into dev with commit 2bf8f73 Nov 11, 2023
13 checks passed
@AidanCaruso AidanCaruso deleted the sitting branch November 11, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants