Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor scopes for bot services #9154

Merged
merged 4 commits into from Nov 1, 2023
Merged

refactor scopes for bot services #9154

merged 4 commits into from Nov 1, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 27, 2023

Summary

馃 Generated by Copilot at 58f9da4

The pull request improves the security and validation of the bot and bot-command services by using the verifyScope hook and disabling or restricting some methods. It requires the bot scope with different permissions for different actions on the bots and their commands.

References

refs #9161

Explanation

馃 Generated by Copilot at 58f9da4

  • Changed the authorization scope for accessing and modifying bots and bot commands (link, link, link, link, link)
  • Removed unnecessary hooks for validating and resolving data for the patch method of the bot-command service (link, link)

馃 Generated by Copilot at 58f9da4

Sing, O Muse, of the code that was changed by the skillful developer
Who removed the redundant hooks and the patch method from bot-command
And who added the verifyScope hook to the bot service with care
To require the proper scope and permission for each action

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@aditya-mitra aditya-mitra marked this pull request as ready for review October 30, 2023 06:33
@barankyle barankyle added this pull request to the merge queue Nov 1, 2023
Merged via the queue into dev with commit d67bd99 Nov 1, 2023
13 checks passed
@barankyle barankyle deleted the refactor/bot-scoping branch November 1, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants