refactor scopes for project
services
#9156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
馃 Generated by Copilot at 3a35966
This pull request updates the scope requirements and the hook logic for various project-related services in the server-core package. It uses the
checkScope
function and theiff
andisProvider
functions fromfeathers-hooks-common
to improve the security and flexibility of the services. It also modifies the tests and thepublish
function to reflect the scope changes. The main services affected areproject-build
,project-invalidate
,project-permission
,project
,scene-upload
,project-github-push
, andscene
.References
refs #9161
Explanation
馃 Generated by Copilot at 3a35966
iff
andisProvider
functions to check external provider and scope for project-related services (link, link, link, link, link, link, link, link)checkScope
function to check user permissions for projects and project permissions (link, link, link, link, link)admin:admin
oreditor:write
toprojects:read
,projects:write
, orscene:write
for various project-related services and functions (link, link, link, link, link, link, link, link, link, link, link, link)await
keyword fromensurePushStatus
function inproject.hooks.ts
(link)checkExistingPermissions
function inproject-permission.hooks.ts
(link)ensureOwnership
function inproject-permission.hooks.ts
to allow users withprojects:read
scope to access project permissions (link)馃 Generated by Copilot at 3a35966
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist