Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to add server logger for all hooks #9162

Merged
merged 3 commits into from Oct 28, 2023
Merged

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Oct 27, 2023

Summary

馃 Generated by Copilot at 54905fa

This pull request adds a new logError hook to the server core module, which logs errors in hooks to the server logger. This enhances the error handling and debugging capabilities of the server core module and other services that use it.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 54905fa

  • Implement and apply logError hook to log errors in hooks to the server logger (link, link, link)
  • Import logError hook from ./hooks/log-error.ts in createApp.ts (link)
  • Add logError hook to the around hook object of the createFeathersKoaApp function in createApp.ts (link)
  • Define and export logError hook in ./hooks/log-error.ts with file comment, license header, and logger initialization (link)

馃 Generated by Copilot at 54905fa

logError is the hook of doom
It catches all the failures in the core
No error can escape its wrath
It writes them all to the server lore

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@hanzlamateen hanzlamateen merged commit 130aa61 into dev Oct 28, 2023
7 checks passed
@hanzlamateen hanzlamateen deleted the hook-errors-logger branch October 28, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants