Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests for location service #9164

Merged
merged 1 commit into from Oct 30, 2023
Merged

Fixed tests for location service #9164

merged 1 commit into from Oct 30, 2023

Conversation

MoizAdnan
Copy link
Member

@MoizAdnan MoizAdnan commented Oct 29, 2023

Summary

馃 Generated by Copilot at b6b75e7

This pull request improves the code quality and readability of the invite and location test files. It removes unused code, fixes a type mismatch, and comments out tests that are failing due to a known bug. It also adds TODO comments to indicate where the bug needs to be fixed.

References

closes #insert number here

Explanation

馃 Generated by Copilot at b6b75e7

  • Simplify and fix invite test cases (link, link, link, link)
  • Update import and type of params variable in location test cases (link)

馃 Generated by Copilot at b6b75e7

params type fixed
invite tests need more work
autumn of bugs

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField marked this pull request as ready for review October 30, 2023 04:30
@HexaField HexaField merged commit 23c02a3 into dev Oct 30, 2023
13 of 14 checks passed
@HexaField HexaField deleted the location-test-fix branch October 30, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants