Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove studio obj3d type #9179

Merged
merged 5 commits into from Oct 31, 2023
Merged

Remove studio obj3d type #9179

merged 5 commits into from Oct 31, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Oct 31, 2023

Summary

馃 Generated by Copilot at 8802570

This pull request refactors the code for the editor components and functions that deal with entities, materials, and properties. It simplifies the type handling and logic by using the Entity type consistently and removing unused or redundant imports, props, and components. It also adds a new material editor panel that allows editing the properties of materials using modular and reusable components.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 8802570

  • Simplified the logic for the hierarchy tree walker and the hierarchy panel by using Entity type instead of EntityOrObjectUUID type and removing unused imports and code (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Added new components for the material editor panel: MaterialProperties and MaterialPropertyTitle, and used them in the MaterialEditor and the EditorContainer components (link, link, link, link, link)
  • Changed the MaterialEditor component to use the materialID prop instead of the material prop and to get the material from the material library state (link, link, link)
  • Changed the MaterialLibraryPanel component to use the selectedMaterial state instead of the selectionState for the material library panel (link, link, link, link, link, link, link)
  • Defined the MaterialSelectionState that stores the selected material ID for the material editor panel (link)
  • Simplified the logic for the properties panel by removing the checks for isMaterial and isObject3D and using the entity directly (link, link)
  • Changed the updateProperty, updateProperties, commitProperty, and commitProperties functions to use the Entity type instead of the EntityOrObjectUUID type (link, link, link, link, link, link)
  • Changed the MaterialInput, CoreNodeEditor, NameInputGroup, NodeEditor, TransformPropertyGroup, and BehaviorInput components to use the Entity type instead of the EntityOrObjectUUID type and to remove unused imports and code (link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Changed the cancelGrabOrPlacement function to use the Entity type instead of the EntityOrObjectUUID type for the removeObject function (link, link)
  • Deleted the SceneObjectInput and Object3DNodeEditor components because they were no longer needed (link, link)
  • Commented out the assignment of prototypeComponent in the MaterialEditor component because it was no longer used in the file (link)

馃 Generated by Copilot at 8802570

Entity type
simplifies editor code
autumn of imports

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField merged commit c20d1fd into dev Oct 31, 2023
7 checks passed
@HexaField HexaField deleted the remove-studio-obj3d-type branch October 31, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant