Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor scopes for cluster services #9184

Merged
merged 2 commits into from Nov 1, 2023
Merged

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 31, 2023

Summary

馃 Generated by Copilot at bfcb829

Improved the security and communication of the cluster services by adjusting the scope and permission hooks for build-status, pods, and api-job. This enables the server to manage the build status and API jobs of the pods without admin rights.

References

refs #9161

Explanation

馃 Generated by Copilot at bfcb829

  • Changed the service hooks for api-job, build-status, and pods to use the server scope instead of the admin scope for external requests (link, link, link). This allows the server to perform various operations on the cluster without requiring admin privileges.

馃 Generated by Copilot at bfcb829

We're the crew of the api-job ship, we sail the code with skill
We don't need admin scope to do our work, we use the server scope at will
Heave away, me hearties, heave away
We'll hook the build-status and the pods with care, and keep them safe and sound

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@barankyle barankyle added this pull request to the merge queue Nov 1, 2023
Merged via the queue into dev with commit 4120579 Nov 1, 2023
13 checks passed
@barankyle barankyle deleted the refactor/cluster-scoping branch November 1, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants