Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behave-graph-query-event-nodes #9195

Merged
merged 6 commits into from Nov 2, 2023
Merged

Behave-graph-query-event-nodes #9195

merged 6 commits into from Nov 2, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Nov 2, 2023

Summary

馃 Generated by Copilot at f6000d1

This pull request adds a new OnQuery node for the behave graph feature, which allows executing logic based on queries of components and entities. It also improves the performance and user experience of the graph editor by using lodash.isEqual and removing unnecessary dependencies. Additionally, it removes or comments out some unused code related to the hierarchy tree component.

References

closes #insert number here

Explanation

馃 Generated by Copilot at f6000d1

  • Import and use isEqual function from lodash to compare graphs and prevent unnecessary updates (link, link)
  • Remove dragging dependency from useEffect hook to avoid triggering reactor on node position changes (link)
  • Comment out unused imports and components related to ErrorComponent and NodeIssuesIcon in HierarchyTreeNode component (link, link, link, link)
  • Add new OnQuery node for behave graph feature in onQuery.ts file, which triggers on query of components and executes flow for each entity in result (link)
  • Import and register OnQuery node in registerEngineProfile.ts file, which registers all engine nodes for behave graph feature (link, link)

馃 Generated by Copilot at f6000d1

OnQuery node
queries the scene, triggers flow
a new autumn leaf

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@SYBIOTE SYBIOTE marked this pull request as draft November 2, 2023 03:39
@SYBIOTE SYBIOTE marked this pull request as ready for review November 2, 2023 03:43
@anselm anselm enabled auto-merge November 2, 2023 15:57
@SYBIOTE SYBIOTE requested a review from anselm November 2, 2023 16:52
@anselm anselm added this pull request to the merge queue Nov 2, 2023
Merged via the queue into dev with commit 0fe32f4 Nov 2, 2023
12 of 13 checks passed
@anselm anselm deleted the behave-graph-query-event-nodes branch November 2, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants