Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor onquery node and add defaults and asserts #9207

Merged
merged 3 commits into from Nov 3, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Nov 3, 2023

This pull request simplifies the onquery node, adds defaults and asserts for nodes, and improves onquery iteration. The changes include:

  • Added Assert to getSpline node to ensure a spline entity is selected

  • Added default values to videoFit and audioMode nodes

  • Renamed getAvatarAnimations to getAnimationPack

  • Added default values to setAnimationAction node

  • Added default values to addEntity node for componentName and parentEntity

  • Improved deleteEntity node by adding a dropdown menu for entity selection

No issues were fixed in this pull request.

Copy link
Collaborator

@anselm anselm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to work

gheric suggests we find a way to remove the delay loop - but that can happen later

i do think the delay could be abstracted away from here in some way - but whatever works

@anselm anselm added this pull request to the merge queue Nov 3, 2023
Merged via the queue into dev with commit 4a3d223 Nov 3, 2023
13 checks passed
@anselm anselm deleted the behave-graph-default-value-for-nodes branch November 3, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants