Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted meshopt decoder from backticked strings to concatenated double quotes #9212

Merged
merged 1 commit into from Nov 4, 2023

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Nov 4, 2023

Summary

Concatenated version was resulting in an invalid Data URL. It might have had to do with the tabs that that was resulting in.

🤖 Generated by Copilot at 42f3989

Reformatted code in meshopt_decoder.module.js to follow ESLint rules and improve readability. No functional changes.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 42f3989

  • Reformatted code in initWorkers function to use consistent indentation, spacing, and single quotes (link)

🤖 Generated by Copilot at 42f3989

initWorkers code
Reformatted for clarity
A fresh spring cleaning

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

…ble quotes

Concatenated version was resulting in an invalid Data URL. It might have had to
do with the tabs that that was resulting in.
@HexaField HexaField merged commit b4409f2 into dev Nov 4, 2023
14 checks passed
@HexaField HexaField deleted the fix-meshopt-source branch November 4, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants