New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
load project routes before app routes #9226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a react-router issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine now.
This reverts commit 8184782.
Summary
馃 Generated by Copilot at 693d2a2
This pull request improves the routing functionality of the client package by refactoring and simplifying the custom routes component and moving it to the
RouterService
class. It also removes an unnecessary console log statement from theRouterService
file.References
closes #9205
Explanation
馃 Generated by Copilot at 693d2a2
RouterService
class and allow custom routes to be defined and rendered dynamically (link, link, link, link, link)CustomRoutes
component fromcustomRoutes.tsx
toRouterService.ts
and added a type annotation for thecustomRoutes
prop (link)CustomRoutes
component by comparing the whole route and pathname strings (link)RouterComp
function inpublic.tsx
to load the custom route component for each case in the switch statement, if it exists, or fall back to the default component (link)loadProjectComponent
inpublic.tsx
(link)getCustomRoutes
function inRouterService.ts
(link)RouteElement
variable in the return statement of theRouterComp
function inpublic.tsx
(link)馃 Generated by Copilot at 693d2a2
QA Steps
Checklist