Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ECS IK target positions from mocap data via rig world positions #9235

Merged
merged 2 commits into from Nov 8, 2023

Conversation

AidanCaruso
Copy link
Member

@AidanCaruso AidanCaruso commented Nov 8, 2023

Summary

馃 Generated by Copilot at 283478f

Refactor applyInputSourcePoseToIKTargets function to take IK target entities as parameters and add support for motion capture rigs. Update AvatarAnimationSystem to use the refactored function and only call it for the local avatar.

References

closes #insert number here

Explanation

馃 Generated by Copilot at 283478f

  • Refactor applyInputSourcePoseToIKTargets function to take IK target entities as parameters instead of generating them from input source UUIDs (link, link, link)
  • Add support for motion capture rig component to applyInputSourcePoseToIKTargets function, using getWorldPosition method to set IK target positions (link, link)
  • Remove unused imports of EntityUUID and UUIDComponent from packages/engine/src/avatar/functions/applyInputSourcePoseToIKTargets.ts (link, link)

馃 Generated by Copilot at 283478f

AvatarAnimationSystem controls our fate
We are the puppets of the execute state
But we can break free from the UUID chains
With applyInputSourcePoseToIKTargets we can use our own motion capture brains

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@AidanCaruso AidanCaruso changed the title Derrive ECS IK targets from mocap data via rig world positions Set ECS IK target positions from mocap data via rig world positions Nov 8, 2023
@anselm anselm added this pull request to the merge queue Nov 8, 2023
Merged via the queue into dev with commit e9d5d1c Nov 8, 2023
14 checks passed
@anselm anselm deleted the ecs-mocap-targets branch November 8, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants