Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file browser configurable top limit #9237

Merged
merged 10 commits into from Nov 20, 2023
Merged

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Nov 8, 2023

Summary

Do not allow to explore all directories in the file browser panels.
Suppress going back when exploring particular project.
Also allow configuring the top limit

References

closes #9220
closes #9221

QA Steps

Back button not present when in the selected project
image

Back button is shown when we go atleast one folder deep
image

Same for studio
image

@aditya-mitra aditya-mitra changed the title file browser top limit file browser configurable top limit Nov 15, 2023
@aditya-mitra aditya-mitra marked this pull request as ready for review November 15, 2023 06:49
Copy link
Member

@barankyle barankyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with clicking on 'projects' in the breadcrumb trail, the part of the file browser that shows the path separated by '>' and lets you click up the folder structure. If you click on 'projects', the API is returning the new error about not being allowed to access that folder, but the frontend doesn't handle that error in any way, and the file browser gets stuck at 'Loading files'.

Ideally, the breadcrumb trail would not show you a folder level that you're not allowed to select - the first item would be . That way, users aren't even aware that there's a folder they can't access. If for some reason that proves overly difficult to implement, then the file browser should catch the new error that the API is returning, remove the loading message, and probably make a notification that that folder is inaccessible.

@aditya-mitra
Copy link
Collaborator Author

There's an issue with clicking on 'projects' in the breadcrumb trail, the part of the file browser that shows the path separated by '>' and lets you click up the folder structure. If you click on 'projects', the API is returning the new error about not being allowed to access that folder, but the frontend doesn't handle that error in any way, and the file browser gets stuck at 'Loading files'.

Ideally, the breadcrumb trail would not show you a folder level that you're not allowed to select - the first item would be . That way, users aren't even aware that there's a folder they can't access. If for some reason that proves overly difficult to implement, then the file browser should catch the new error that the API is returning, remove the loading message, and probably make a notification that that folder is inaccessible.

Implemented!

Screenshot 2023-11-16 at 6 11 01 PM

@barankyle barankyle added this pull request to the merge queue Nov 20, 2023
Merged via the queue into dev with commit 0753030 Nov 20, 2023
13 checks passed
@barankyle barankyle deleted the feat/file-browser-top-limit branch November 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File browser should not be restricted to projects folder File browser should have top level limit
3 participants