New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mocap pose based interactions #9255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBelmes
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointed some things out. I approve. I think we need @HexaField networking eyes as i have not downloaded that info into my brain.
…ngine/etherealengine into mocap-pose-interaction
HexaField
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lays the groundwork for an extensible pose based interaction system. The first mocap pose based event included in this PR is seat detection via interaction actions recieved by mount point components. Sitting with full body motion capture next to a seat will run the mount point component's seated logic. Standing up should also cause the avatar to leave the seat.
The interaction action/onInteract function has been replaced in favor of directly accessing input sources through the input source component, this also required some code changes in the grabbable system. In a similar vein, the local pose component is used to manage mocap pose inputs after pose detection. For now, the only integrated poses are sitting and standing, though pose types can be extended to any theoretically detectable pose. Pose detection for the seated/standing position is done through a reusable function that compares upper leg angles relative to the hips.
References
closes #insert number here
QA Steps