Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocap pose based interactions #9255

Merged
merged 71 commits into from Dec 5, 2023
Merged

Mocap pose based interactions #9255

merged 71 commits into from Dec 5, 2023

Conversation

AidanCaruso
Copy link
Member

@AidanCaruso AidanCaruso commented Nov 10, 2023

Summary

Lays the groundwork for an extensible pose based interaction system. The first mocap pose based event included in this PR is seat detection via interaction actions recieved by mount point components. Sitting with full body motion capture next to a seat will run the mount point component's seated logic. Standing up should also cause the avatar to leave the seat.

The interaction action/onInteract function has been replaced in favor of directly accessing input sources through the input source component, this also required some code changes in the grabbable system. In a similar vein, the local pose component is used to manage mocap pose inputs after pose detection. For now, the only integrated poses are sitting and standing, though pose types can be extended to any theoretically detectable pose. Pose detection for the seated/standing position is done through a reusable function that compares upper leg angles relative to the hips.

References

closes #insert number here

QA Steps

  • Go to studio/default-project/apartment
  • Add an entity with a mount point component
  • Visit location/apartment
  • Stand near the mount point component in the location
  • Open the capture page
  • Sit down in view of the camera
  • Avatar should snap to the mount
  • Stand up
  • Avatar should dismount

@AidanCaruso AidanCaruso marked this pull request as draft November 22, 2023 22:29
@AidanCaruso AidanCaruso marked this pull request as ready for review November 27, 2023 16:07
Copy link
Contributor

@DanielBelmes DanielBelmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed some things out. I approve. I think we need @HexaField networking eyes as i have not downloaded that info into my brain.

packages/engine/src/mocap/poseToInput.ts Outdated Show resolved Hide resolved
@AidanCaruso AidanCaruso added this pull request to the merge queue Dec 5, 2023
Merged via the queue into dev with commit fd1aab0 Dec 5, 2023
13 checks passed
@AidanCaruso AidanCaruso deleted the mocap-pose-interaction branch December 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants