Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locations refer to scene by path rather than name #9300

Merged
merged 16 commits into from Nov 22, 2023
Merged

Locations refer to scene by path rather than name #9300

merged 16 commits into from Nov 22, 2023

Conversation

MoizAdnan
Copy link
Member

@MoizAdnan MoizAdnan commented Nov 15, 2023 •
edited

Summary

  • Location.sceneId now contains the path to scene file instead of 'projectName/sceneName'.
  • Scenes load without redirecting
  • Changes in scene class for multitenancy

References

closes #9263

QA Steps

@MoizAdnan MoizAdnan marked this pull request as ready for review November 21, 2023 17:58
@speigg
Copy link
Member

speigg commented Nov 22, 2023

This is great, much simpler.

@speigg speigg added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit ade61f3 Nov 22, 2023
8 checks passed
@speigg speigg deleted the location-scene branch November 22, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speigg speigg speigg approved these changes

@HexaField HexaField Awaiting requested review from HexaField

@barankyle barankyle Awaiting requested review from barankyle

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locations refer to scene by path rather than name
2 participants
@MoizAdnan @speigg