Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mesh material editor with inputs #9309

Merged
merged 3 commits into from Nov 20, 2023
Merged

fix mesh material editor with inputs #9309

merged 3 commits into from Nov 20, 2023

Conversation

aditya-mitra
Copy link
Collaborator

Summary

Fix name showing as [object Object] in mesh material edtor
Fix scroll flickering going to top of editor when changing a value
Fix overflowing scrubber inputs in texture preview

References

QA Steps

Earlier

bc157ef8-8a5d-42bd-ba25-6be800814b6d.webm

Now

7e3c74bd-669d-40fd-9055-63965d2add23.webm

Copy link
Contributor

@DanielBelmes DanielBelmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see that you've removed a state that tracked loading. I'm not familiar with it myself but trust that removing it doesn't regress any UX.

@dinomut1 dinomut1 added this pull request to the merge queue Nov 20, 2023
Merged via the queue into dev with commit ce854ad Nov 20, 2023
13 checks passed
@dinomut1 dinomut1 deleted the fix/material-editor branch November 20, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants